Artem Vasiliev asked for the Mix rake stats… here they are:
+----------------------+-------+-------+---------+---------+-----+-------+ | Name | Lines | LOC | Classes | Methods | M/C | LOC/M | +----------------------+-------+-------+---------+---------+-----+-------+ | Controllers | 1825 | 1504 | 22 | 145 | 6 | 8 | | Helpers | 248 | 217 | 0 | 28 | 0 | 5 | | Models | 976 | 802 | 20 | 105 | 5 | 5 | | Libraries | 463 | 364 | 7 | 45 | 6 | 6 | | Components | 0 | 0 | 0 | 0 | 0 | 0 | | Integration tests | 0 | 0 | 0 | 0 | 0 | 0 | | Functional tests | 3904 | 3087 | 24 | 89 | 3 | 32 | | Unit tests | 771 | 604 | 1 | 10 | 10 | 58 | +----------------------+-------+-------+---------+---------+-----+-------+ | Total | 8187 | 6578 | 74 | 422 | 5 | 13 | +----------------------+-------+-------+---------+---------+-----+-------+ Code LOC: 2887 Test LOC: 3691 Code to Test Ratio: 1:1.3
Rails mantra is “fat models and skinny controllers” 🙂 In your case controllers seem to be more fat than models. Why is it so?
Rails mantra is “fat models and skinny controllers” 🙂 In your case controllers seem to be more fat than models. Why is it so?
We’re familiar with the credo. Don’t let the numbers fool you. Our controllers are actually pretty skinny (and our models are pretty fat). We just have lots of controller actions. And… to by honest, there’s quite a bit of refactoring to be done.
If we ever open source the code, you’ll see.
We’re familiar with the credo. Don’t let the numbers fool you. Our controllers are actually pretty skinny (and our models are pretty fat). We just have lots of controller actions. And… to by honest, there’s quite a bit of refactoring to be done.
If we ever open source the code, you’ll see.
That rule might not apply for JRuby… Or should I say, “all benchmarks lie”?
In JRuby, one line in the ‘model’ might represent an invocation of one hundred lines of Java.
Unless rake stats are smart enough to follow invoked Java code, count lines, and add that to the report… in which case, I’m impressed 😉
That rule might not apply for JRuby… Or should I say, “all benchmarks lie”?
In JRuby, one line in the ‘model’ might represent an invocation of one hundred lines of Java.
Unless rake stats are smart enough to follow invoked Java code, count lines, and add that to the report… in which case, I’m impressed 😉
If you want the Mix code to be opened, vote for this idea:
https://mix.oracle.com/ideas/open-source-mix-code
If you want the Mix code to be opened, vote for this idea:
https://mix.oracle.com/ideas/open-source-mix-code
bex, rake stats just counts the pure ruby code, irregardless of what it’s running under (MRI or JRuby). It’s a count of how much code we actually wrote.
bex, rake stats just counts the pure ruby code, irregardless of what it’s running under (MRI or JRuby). It’s a count of how much code we actually wrote.
Thank you, this was interesting!
I thought the Mix is smaller.. and impressed by the code/test ratio )
Thank you, this was interesting!
I thought the Mix is smaller.. and impressed by the code/test ratio )